MultiTierLinqToSql Issue Tracker Rss Feed

Closed Issue: Bugs in PrimaryKeyName and UpdateOriginalFromChanged [4680]

taliesins — Wed, 30 Sep 2009 10:30:13 GMT

I've just tried updating a project to use version 2.0, and come across a couple of major problems with some of my existing code that uses the GetEntity and UpdateOriginalFromChanged.

In order to make the minimum of changes I have replaced the previous inheritance from GenericController with inheritance from StaticGenericRepository, however when I'm calling GetEntity, this is throwing a null reference exception. This looks to be being caused by the Get method for the PrimaryKeyName property which is returning primaryKey.MappedName at line 156 which is then used to try and find the primary key property - using primaryKey.Name instead allows this to work.

There is a similar problem in UpdateOriginalFromChanged, where the DatabaseProperties method is again using dm.MappedName at line 199.

Both of these bugs would only be apparent when using DBML that renames some of the columns - MappedName is the name of the underlying database field, which in our case is different from the property names in the LINQ data model.
Comments:

Commented Issue: Bugs in PrimaryKeyName and UpdateOriginalFromChanged [4680]

taliesins — Wed, 30 Sep 2009 09:55:51 GMT

Yes you are totally correct. Thanks for catching this bug. It will be updated in future versions

Commented Issue: Bug in GenericController.GetEntity(object id) when using a Guid [3781]

taliesins — Wed, 30 Sep 2009 09:22:17 GMT

First of all, great work with this library! I'm building a website using Linq To Sql and this library has been a lifesaver when dealing with the DataContext issues.

The GetEntity method will throw a SqlException because the Guid value is not quoted in the select query. I found a solution around the error, but i'm not 100% sure if this will work in all situations (Currently it's only tested having a Guid as primary key).

I replaced the body of the GetEntity method with:

ParameterExpression paramExpr = Expression.Parameter(typeof(TEntity), "e");
Expression<Func<TEntity, bool>> predicate = Expression.Lambda<Func<TEntity, bool>>(Expression.Equal(Expression.Property(paramExpr, PrimaryKeyDBColumnName), Expression.Constant(id)), paramExpr);
return EntityTable.FirstOrDefault(predicate);

Any feedback on this solution is greatly appreciated
Comments: ** Comment from web user: taliesins **

I suspect that the problem lies in the following line.

Change:
ConstantExpression value = Expression.Constant(Convert.ChangeType(id, primaryKey.Type));

To:
ConstantExpression value = Expression.Constant(Convert.ChangeType(id, primaryKey.Type), primaryKey.Type);

Created Issue: Bugs in PrimaryKeyName and UpdateOriginalFromChanged

RTPeat — Fri, 03 Jul 2009 15:26:52 GMT

Created Issue: Bug in GenericController.GetEntity(object id) when using a Guid

vl_itchie — Wed, 11 Feb 2009 15:16:49 GMT